Illumos/gate 8ab441eusr/src/uts/common/sys/scsi/targets stdef.h

16536 st: this 'if' clause does not guard...
Reviewed by: Gordon Ross <Gordon.W.Ross at gmail.com>
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Reviewed by: Vitaliy Gusev <gusev.vitaliy at gmail.com>
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+37-28usr/src/uts/common/sys/scsi/targets/stdef.h
+37-281 files

Illumos/gate c8c973dusr/src/boot Makefile.version, usr/src/boot/efi/libefi efi_console.c

14321 loader.efi: to preserve heap space, use AllocatePages() for shadow_fb
Reviewed by: Gordon Ross <Gordon.W.Ross at gmail.com>
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+17-4usr/src/boot/efi/libefi/efi_console.c
+1-1usr/src/boot/Makefile.version
+18-52 files

Illumos/gate 9d9f553usr/src/uts/common/io/fibre-channel/fca/qlc ql_fm.c

16549 qlc: the comparison will always evaluate as 'true'
Reviewed by: Gordon Ross <Gordon.W.Ross at gmail.com>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+1-2usr/src/uts/common/io/fibre-channel/fca/qlc/ql_fm.c
+1-21 files

Illumos/gate 0a37194usr/src/cmd/smbsrv/smbd smbd.h

16532 smbd: conflicting types for 'smbd_logon_final'
Reviewed by: Gordon Ross <Gordon.W.Ross at gmail.com>
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Reviewed by: Vitaliy Gusev <gusev.vitaliy at gmail.com>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+1-1usr/src/cmd/smbsrv/smbd/smbd.h
+1-11 files

Illumos/gate 16f0f9busr/src/cmd/savecore savecore.c Makefile

16547 savecore should report progress when saving compressed dump
Reviewed by: Robert Mustacchi <rm+illumos at fingolfin.org>
Reviewed by: Rich Lowe <richlowe at richlowe.net>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+50-23usr/src/cmd/savecore/savecore.c
+4-2usr/src/cmd/savecore/Makefile
+54-252 files

Illumos/gate cde3e94usr/src/pkg/manifests driver-storage-mpt_sas.p5m, usr/src/uts/common/io/scsi/adapters/mpt_sas mptsas.c mptsas_impl.c

16524 driver for 38xx HBA in illumos
Reviewed by: Dan McDonald <danmcd at mnx.io>
Reviewed by: Hans Rosenfeld <rosenfeld at grumpf.hope-2000.org>
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Reviewed by: Dale Ghent <daleg at elemental.org>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+72-15usr/src/uts/common/io/scsi/adapters/mpt_sas/mptsas.c
+31-13usr/src/uts/common/io/scsi/adapters/mpt_sas/mptsas_impl.c
+13-3usr/src/uts/common/sys/scsi/adapters/mpt_sas/mptsas_var.h
+4-1usr/src/uts/common/io/scsi/adapters/mpt_sas/mptsas_init.c
+3-1usr/src/pkg/manifests/driver-storage-mpt_sas.p5m
+3-0usr/src/uts/common/sys/scsi/adapters/mpi/mpi2_cnfg.h
+126-336 files

Illumos/gate ce7a304usr/src/cmd/fm/modules/common/zfs-retire zfs_retire.c, usr/src/man/man8 zpool.8

16429 zpool hot spare replacement not grabbing similar/appropriate sized drive
Reviewed by: Jason King <jason.brian.king+illumos at gmail.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+98-0usr/src/test/zfs-tests/tests/functional/fault/auto_spare_sorted_001_pos.ksh
+58-13usr/src/cmd/fm/modules/common/zfs-retire/zfs_retire.c
+5-1usr/src/man/man8/zpool.8
+3-0usr/src/pkg/manifests/system-test-zfstest.p5m
+1-1usr/src/test/zfs-tests/runfiles/common.run
+165-155 files

Illumos/gate 2c6ce8cusr/src/lib/libnvme/common libnvme_impl.h

16535 libnvme: argument 1 with mismatched bound
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Luqman Aden <luqman at oxide.computer>
Reviewed by: Vitaliy Gusev <gusev.vitaliy at gmail.com>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
DeltaFile
+1-1usr/src/lib/libnvme/common/libnvme_impl.h
+1-11 files

Illumos/gate ee07306usr/src/cmd/svc/svccfg svccfg.h

16528 clean up low-hanging warnings in svccfg(8) (duplicate definition)
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+2-5usr/src/cmd/svc/svccfg/svccfg.h
+2-51 files

Illumos/gate 9d9f943usr/src/lib/libnvme/common libnvme_log.c

16534 libnvme: conflicting types for 'nvme_log_req_set_csi'
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Luqman Aden <luqman at oxide.computer>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+1-1usr/src/lib/libnvme/common/libnvme_log.c
+1-11 files

Illumos/gate 4d8d108usr/src/man/man3sec acl_totext.3sec

16542 Document ACL_NORESOLVE flag for acl_totext
Reviewed by: Peter Tribble <peter.tribble at gmail.com>
Reviewed by: Gordon Ross <Gordon.W.Ross at gmail.com>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+13-2usr/src/man/man3sec/acl_totext.3sec
+13-21 files

Illumos/gate 321abbausr/src/uts/common/io/vioif vioif.c

16511 vioif_reclaim_tx() is holding lock across calling mac_tx_update
Reviewed by: Jason King <jason.brian.king+illumos at gmail.com>
Reviewed by: Joshua M. Clulow <josh at sysmgr.org>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>
DeltaFile
+1-1usr/src/uts/common/io/vioif/vioif.c
+1-11 files

Illumos/gate 54819d4usr/src/man/man4p tcp.4p, usr/src/test/os-tests/tests/tcpsig tcpsig.c

16525 TCP_MD5SIG listening socket should degrade gracefully
Reviewed by: Robert Mustacchi <rm+illumos at fingolfin.org>
Reviewed by: Dan McDonald <danmcd at mnx.io>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>
DeltaFile
+73-56usr/src/uts/common/inet/tcp/tcp_sig.c
+36-5usr/src/test/os-tests/tests/tcpsig/tcpsig.c
+28-9usr/src/uts/common/inet/tcp/tcp_input.c
+9-5usr/src/man/man4p/tcp.4p
+4-0usr/src/uts/common/inet/tcp/tcp_stats.c
+2-0usr/src/uts/common/inet/tcp_stats.h
+152-752 files not shown
+154-768 files

Illumos/gate 3ade830usr/src/uts/common/io ptem.c

16529 TIOCGWINSZ returns EINVAL on a freshly-created pty
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+0-9usr/src/uts/common/io/ptem.c
+0-91 files

Illumos/gate e2a8479usr/src/uts/common/io clone.c, usr/src/uts/intel/clone Makefile

16516 clone: smatch errors
Reviewed by: Gordon Ross <gordon.w.ross at gmail.com>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+3-3usr/src/uts/common/io/clone.c
+0-3usr/src/uts/intel/clone/Makefile
+3-62 files

Illumos/gate 98f0a99usr/src/uts/common/io/scsi/adapters/lmrc lmrc_reg.h lmrc_phys.h, usr/src/uts/common/sys/scsi/adapters/mfi mfi.h mfi_evt.h

16477 lmrc: move MFI definitions into their own headers
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Reviewed by: Gordon Ross <Gordon.W.Ross at gmail.com>
Reviewed by: Jason King <jason.brian.king+illumos at gmail.com>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+833-0usr/src/uts/common/sys/scsi/adapters/mfi/mfi.h
+3-784usr/src/uts/common/io/scsi/adapters/lmrc/lmrc_reg.h
+310-0usr/src/uts/common/sys/scsi/adapters/mfi/mfi_evt.h
+260-0usr/src/uts/common/sys/scsi/adapters/mfi/mfi_pd.h
+238-0usr/src/uts/common/sys/scsi/adapters/mfi/mfi_ld.h
+3-219usr/src/uts/common/io/scsi/adapters/lmrc/lmrc_phys.h
+1,647-1,00311 files not shown
+2,078-1,27417 files

Illumos/gate ce43180usr/src/boot Makefile.version, usr/src/boot/efi/loader framebuffer.c

14320 loader.efi: Do not use as frame buffer BLT-only GOPs.
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Sebastian Wiedenroth <wiedi at frubar.net>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>
DeltaFile
+18-5usr/src/boot/efi/loader/framebuffer.c
+1-1usr/src/boot/Makefile.version
+19-62 files

Illumos/gate 4e0cc57usr/src/common/crypto/sha1 sha1.c, usr/src/test/crypto-tests/tests/longhash longhash.c

16350 SHA1 may produce incorrect hashes if given a 2^29 byte input
Reviewed by: Robert Mustacchi <rm+illumos at fingolfin.org>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>
DeltaFile
+55-3usr/src/test/crypto-tests/tests/longhash/longhash.c
+30-6usr/src/common/crypto/sha1/sha1.c
+85-92 files

Illumos/gate b960b5eusr/src/cmd/svc/common notify_params.c, usr/src/cmd/svc/svccfg svccfg.h svccfg.y

16528 clean up low-hanging warnings in svccfg(8)
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Reviewed by: Jason King <jason.brian.king+illumos at gmail.com>
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+121-100usr/src/cmd/svc/svccfg/svccfg.h
+5-3usr/src/cmd/svc/common/notify_params.c
+3-3usr/src/cmd/svc/svccfg/svccfg.y
+3-3usr/src/cmd/svc/svccfg/Makefile
+1-1usr/src/cmd/svc/svccfg/svccfg_libscf.c
+1-0usr/src/cmd/svc/svccfg/svccfg_main.c
+134-1106 files

Illumos/gate c7685b3usr/src/cmd/mdb/common/modules/ip ip.c

16510 mdb incorrectly prints the IPv6 Traffic Class
Reviewed by: Gordon Ross <Gordon.W.Ross at gmail.com>
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+2-1usr/src/cmd/mdb/common/modules/ip/ip.c
+2-11 files

Illumos/gate 89cf0c2usr/src/uts/common/inet/ipf fil.c ip_proxy.c, usr/src/uts/common/inet/ipf/netinet ip_compat.h

16521 ipf kernel panic while initialising statistics on low memory system
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
DeltaFile
+5-1usr/src/uts/common/inet/ipf/fil.c
+2-0usr/src/uts/common/inet/ipf/netinet/ip_compat.h
+2-0usr/src/uts/common/inet/ipf/ip_proxy.c
+9-13 files

Illumos/gate dadf5efusr/src/test/zfs-tests/tests/functional/cli_root/zfs_property zfs_written_property_001_pos.ksh

12023 zfs test zfs_written_property_001_pos can fail
Portions contributed by: John Wren Kennedy <john.kennedy at delphix.com>
Reviewed by: Gordon Ross <Gordon.W.Ross at gmail.com>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+13-13usr/src/test/zfs-tests/tests/functional/cli_root/zfs_property/zfs_written_property_001_pos.ksh
+13-131 files

Illumos/gate 72af5a4usr/src/lib/libc/port/locale strftime.c, usr/src/pkg/manifests system-test-libctest.p5m

16352 strftime_l() should be more careful with pointer arithmetic
Reviewed by: Gordon Ross <Gordon.W.Ross at gmail.com>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+89-0usr/src/test/libc-tests/tests/ascftime.c
+24-2usr/src/lib/libc/port/locale/strftime.c
+2-0usr/src/test/libc-tests/runfiles/default.run
+2-0usr/src/pkg/manifests/system-test-libctest.p5m
+1-0usr/src/test/libc-tests/tests/Makefile
+118-25 files

Illumos/gate f386ca6usr/src/cmd/cmd-inet/usr.sbin/snoop snoop_ip.c

16508 snoop incorrectly prints the IPv6 Traffic Class
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Vitaliy Gusev <gusev.vitaliy at gmail.com>
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>
DeltaFile
+5-4usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_ip.c
+5-41 files

Illumos/gate 1696d86usr/src/cmd/cmd-inet/usr.bin/nc netcat.c, usr/src/man/man1 nc.1

16491 netcat should support setting the outgoing and minimum TTL
16501 netcat should support setting IPV6_TCLASS for ipv6 sockets
16507 nc missing TCP MD5 in usage and help
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Dan Cross <cross at oxidecomputer.com>
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+112-32usr/src/cmd/cmd-inet/usr.bin/nc/netcat.c
+25-3usr/src/man/man1/nc.1
+137-352 files

Illumos/gate 4ac140busr/src/uts/common/fs/zfs vdev.c vdev_label.c

16502 panic in zfs:abd_iter_map
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>
DeltaFile
+12-0usr/src/uts/common/fs/zfs/vdev.c
+10-0usr/src/uts/common/fs/zfs/vdev_label.c
+2-5usr/src/uts/common/fs/zfs/vdev_indirect.c
+24-53 files

Illumos/gate 3887472usr/src/uts/common/inet/tcp tcp_sig.c

16519 panic when removing SADB entry with tcpkey delete
Reviewed by: Robert Mustacchi <rm+illumos at fingolfin.org>
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>
DeltaFile
+10-13usr/src/uts/common/inet/tcp/tcp_sig.c
+10-131 files

Illumos/gate eac40bbexception_lists closed-bins

16498 closed nfs dmod/kmod are still delivered
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+2-0exception_lists/closed-bins
+2-01 files

Illumos/gate a87f5a4usr/src/uts/common/rpc clnt_clts.c

16387 CLSET_NODELAYONERR not set if udp transport is used.
Reviewed by: Dan McDonald <danmcd at mnx.io>
Reviewed by: Gordon Ross <gordon.w.ross at gmail.com>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
DeltaFile
+11-0usr/src/uts/common/rpc/clnt_clts.c
+11-01 files

Illumos/gate e0c5eaausr/src/common/nvme nvme_log.c

16484 libnvme should take care of unaligned log page sizes
Reviewed by: Michael Zeller <mike at mikezeller.net>
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>
DeltaFile
+15-2usr/src/common/nvme/nvme_log.c
+15-21 files