OPNSense/core df8d12c — src/opnsense/mvc/app/controllers/OPNsense/Monit/Api SettingsController.php ServiceController.php, src/opnsense/mvc/app/controllers/OPNsense/Monit/forms services.xml alerts.xml
Monit, major cleanup, related to https://github.com/opnsense/core/pull/3119
- remove locking in model, core framework should do that if required. (see Config->lock), deadlock issues in previous code (freezing UI)
- in settings controller, expand endpoints to one per type (in stead of "one to rule them all")
- in settings controller, align to base wrappers of ApiMutableModelControllerBase
- move extended validations to model, to avoid validation issues when another service would like to reuse the model
- align forms to standard wrappers (naming convention, simplifies code)
- remove "deleteRelations", if we need something like this at some point, it should be in the model, for now it seems safe enough to ditch
- ditch migration code, since it does the same as having a default value (defaults are always enforced during migrations)
** left UnitTest code for what it is now, probably needs changes too
UnifiedSplitRaw
