OpenBSD/src KjXVMFdusr.bin/lock lock.c

   While -n is now the default, it's been useful since 1996.  Keep it for compat.

   Agreement from schwarze@ (who proposed a thorough but longer diff) and millert@
   ok tb@ kn@ cheloha@
VersionDeltaFile
1.45+5-2usr.bin/lock/lock.c
+5-21 files

OpenBSD/src mpsXoBjsbin/dhclient parse.c

   Restructure parse_semi() so it resembles the other parse_*
   functions.
VersionDeltaFile
1.82+8-7sbin/dhclient/parse.c
+8-71 files

OpenBSD/src TyrbDwOsbin/dhclient clparse.c parse.c

   Replace malloc()/memcpy() with strdup() in parse_string(). Nuke 'len' parameter
   to parse_string() in favour of taking strlen() of resulting string in the few
   cases that it is of interest.
VersionDeltaFile
1.190+13-11sbin/dhclient/clparse.c
1.81+4-7sbin/dhclient/parse.c
1.280+2-2sbin/dhclient/dhcpd.h
+19-203 files

OpenBSD/src o4tCXoFusr.sbin/pkg_add/OpenBSD Error.pm

   tweak register a bit... END {} code is obviously the problem
VersionDeltaFile
1.37+36-11usr.sbin/pkg_add/OpenBSD/Error.pm
+36-111 files

OpenBSD/src HAZGRxRusr.bin/lock lock.c

   Amend comment: entering the root password won't unlock the terminal

   Mention -p (user password) while here.
VersionDeltaFile
1.44+3-3usr.bin/lock/lock.c
+3-31 files

OpenBSD/src 9xtE5x4usr.sbin/pkg_add/OpenBSD Error.pm

   gc old functions, that part is clean as well...
   so it's obviously the END code then...
VersionDeltaFile
1.36+2-86usr.sbin/pkg_add/OpenBSD/Error.pm
+2-861 files

OpenBSD/src 9xrxlQkusr.sbin/pkg_add/OpenBSD AddDelete.pm PkgCreate.pm

   start re-adding the non-broken changes:
   - commonalize try{} catch {} for pkg_add/delete and pkg_create, so that
   debug works the same way in both.
   - switch printing command name to the catch handler, so that exceptions
   are simpler to handle

OpenBSD/src X12xxpQsys/kern vfs_vnops.c

   Grab the vnode lock in vn_seek(). Consensus has emerged around using the
   existing vnode lock to protect writes to the f_offset field of struct
   file. As opposed of introducing a new lock which turned out to be harder
   than anticipated.

   ok mpi@ visa@
VersionDeltaFile
1.102+16-8sys/kern/vfs_vnops.c
+16-81 files

OpenBSD/src LwZWRJLsys/dev/pci/drm drm_panel_orientation_quirks.c

   add a panel orientation quirk for Kogan Atlas 2-in-1 D300

   reported and tested by Peter Kane

OpenBSD/src xfj8JcSsys/dev/pci if_ixl.c

   apply backpressure when ifiq says the stack is getting busy
VersionDeltaFile
1.40+23-4sys/dev/pci/if_ixl.c
+23-41 files

OpenBSD/src ImkLqcSlibexec/ld.so resolve.c loader.c

   In 2004, we upgraded to binutils 2.14 with did -zcombreloc by default.
   In 2013, I implemented the single-entry LRU cache that gets the maximal
   symbol reuse from combreloc.  Since then, the ld.so generic relocation
   symcache has been a waste of CPU and memory with 0% hit-rate, so kill it.

   ok mpi@

OpenBSD/src l5cmbBUsys/arch/macppc/dev zs.c, sys/arch/sparc64/sparc64 ipifuncs.c

   Get rid of `ddb_is_active' instead use `db_active'.

   From Christian Ludwig <christian_ludwig at genua dot de>

   ok visa@

OpenBSD/src 20Onq4Xsys/arch/m88k/m88k db_interface.c, sys/arch/powerpc/powerpc trap.c

   Increment `db_active' before entering db_trap() like other archs do.

   ok visa@

OpenBSD/src rWzRjJqsys/net if_bridge.c

   When multiple ports share the same MAC, pick the physical one for delivery.

   Fix an issue reported by Eygene Ryabinkin where packet where dropped by
   pf(4) because a vlan(4) interface was picked instead of its underlying
   em(4).

   While here do some refactoring to avoid code duplication.

   Based on a submission from Eygene Ryabinkin <rea at codelabs dot ru>.

   ok bluhm@, kn@
VersionDeltaFile
1.337+39-31sys/net/if_bridge.c
+39-311 files

OpenBSD/src GsUu9lBsbin/dhclient clparse.c

   Use same 'switch (token) ...' idiom in parse_lease_decl() and
   parse_conf_decl(). Smaller, less confusing.

   No intentional functional change.
VersionDeltaFile
1.189+94-109sbin/dhclient/clparse.c
+94-1091 files

OpenBSD/src PmubCousbin/dhclient clparse.c

   Sort TOK_USELEASE case into proper alphabetic location in
   switch statement. Nuke TOK_LEASE handling (neutered since
   2017) in config file.
VersionDeltaFile
1.188+24-27sbin/dhclient/clparse.c
+24-271 files

OpenBSD/src chEXfDibin/ed ed.1

   1. Correct the description of the g command to match POSIX and our
   implementation; it was oversimplified and arguably incorrect.
   2. Explicitely compare the behaviour of empty command lists for g,
   empty command lists for G, and empty commands because these subtle
   differences are quite confusing.
   3. Say more precisely what the v and V commands do, avoiding the
   fuzzy wording "similar".
   All these issues were first pointed out by martijn@.
   Feedback and OK martijn@; "diff reads ok" jmc@ on an earlier version.
VersionDeltaFile
1.74+27-21bin/ed/ed.1
+27-211 files

OpenBSD/src omAhMlRusr.bin/less less.1

   Correct misleading description of -S;
   problem reported by Ralf dot Schuelke at gmail dot com on bugs@.
VersionDeltaFile
1.55+4-6usr.bin/less/less.1
+4-61 files

OpenBSD/src TlbW7urusr.bin/mg interpreter.c

   Missed a free.
VersionDeltaFile
1.5+2-1usr.bin/mg/interpreter.c
+2-11 files

OpenBSD/src 9Fh4mctregress/usr.bin/ssh forwarding.sh

   Remove the sleeps and thus races from the forwarding test.  They were
   originally required to work with Protocol 1, but now we can use ssh -N
   and the control socket without the sleeps. While there, suppress output
   fro the control exit commands.
VersionDeltaFile
1.23+19-21regress/usr.bin/ssh/forwarding.sh
+19-211 files

OpenBSD/src rXQp32Kregress/usr.bin/ssh forwarding.sh

   Allow SLEEPTIME to be overridden.
VersionDeltaFile
1.22+2-2regress/usr.bin/ssh/forwarding.sh
+2-21 files

OpenBSD/src Gix1Jn4regress/usr.bin/ssh forwarding.sh

   Move sleep time into a variable so that we can increase it for platforms
   or configurations that are much slower then usual.
VersionDeltaFile
1.21+11-9regress/usr.bin/ssh/forwarding.sh
+11-91 files

OpenBSD/src MDWxpLWusr.bin/mg interpreter.c

   Move a bit of code to where it is called only if needed.
VersionDeltaFile
1.4+5-5usr.bin/mg/interpreter.c
+5-51 files

OpenBSD/src 36T68K4sys/net if_aggr.c

   generate the actor info per port to send to userland.

   useful for debugging.
VersionDeltaFile
1.18+7-0sys/net/if_aggr.c
+7-01 files

OpenBSD/src cCvDcN2sys/net if_aggr.c

   just use LINK_STATE_IS_UP to see if a port has link.

   excluding HALF_DUPLEX just seems mean.
VersionDeltaFile
1.17+2-8sys/net/if_aggr.c
+2-81 files

OpenBSD/src 32JBb6Bsbin/ping ping.c

   ping(8): don't round inter-packet delay up to HZ

   ping(8) doesn't know the value of HZ and shouldn't round the user's
   packet wait up to whatever it thinks HZ is.  If the period is too small
   the interrupt will simply fire less often than instructed.  The kernel
   will do the right thing regardless.

   Given the rarity of this usage we don't really need to print a warning,
   either.

   ok millert@
VersionDeltaFile
1.237+1-6sbin/ping/ping.c
+1-61 files

OpenBSD/src FZyVYveusr.bin/mandoc main.c term_ascii.c

   #define a handful of constant strings to reduce the diff to -portable;
   now, the diff is about -30 +150 lines (about 0.4%)
VersionDeltaFile
1.235+14-8usr.bin/mandoc/main.c
1.50+4-2usr.bin/mandoc/term_ascii.c
+18-102 files

OpenBSD/src JOtht85sbin/dhclient dhclient.c clparse.c

   Nuke a bunch of 'name' parameters that haven't been used since
   dhclient(8) stopped writing interface names in the leases file.
VersionDeltaFile
1.646+15-16sbin/dhclient/dhclient.c
1.187+8-9sbin/dhclient/clparse.c
1.279+2-2sbin/dhclient/dhcpd.h
+25-273 files

OpenBSD/src htkgBdsusr.sbin/config config.8 main.c

   In the synopsis, put options that take no arguments before those that do.
   This also makes it easier to find the crucial difference between the
   two synopses, which is the "-e".
   Suggested by kn@; OK jmc@.
VersionDeltaFile
1.68+3-3usr.sbin/config/config.8
1.61+2-2usr.sbin/config/main.c
+5-52 files

OpenBSD/src X1HDJo5usr.bin/mandoc tag.c main.c

   If no tags were generated at all, unlink(2) the empty tags file as
   soon the condition can be detected and do not pass it to less(1).
   This may happen for man(7) pages, for preformatted pages, and for
   very simple pages like true(1).  The main benefit is that :t inside
   less(1) yields the clearer diagnostic message "No tags file" rather
   than the mildly confusing "No such tag in tags file": the latter
   might encourage further, futile attempts to jump to other tags.

   Improvement suggested by Leah Neukirchen <leah at vuxu dot org>
   from The Void.
VersionDeltaFile
1.23+12-3usr.bin/mandoc/tag.c
1.234+2-2usr.bin/mandoc/main.c
+14-52 files

OpenBSD/src FIntFAllib/libc/time strptime.3

   Update POSIX reference to the 2008 version and correct the list of
   conversion specifications that are extensions; issues reported by
   Andras Farkas <deepbluemistake at gmail dot com> on misc@.

   While here, note that alternative conversion modifiers have no effect
   and that flags and field width specifications are not supported.
VersionDeltaFile
1.30+11-6lib/libc/time/strptime.3
+11-61 files

OpenBSD/src SWiJEmxusr.bin/lock lock.c lock.1

   lock(1): remove default timeout

   It makes little sense from a security standpoint to unlock the terminal
   and expose the user's session after fifteen minutes by default.

   Default behavior is now to reserve the terminal forever.  Add instructions
   to the manpage to help the user employ the -t timeout option more safely.

   Manpage greatly improved by jmc@; bug(s) caught by millert@; with input
   from claudio@.

   ok millert@
VersionDeltaFile
1.43+10-24usr.bin/lock/lock.c
1.19+10-16usr.bin/lock/lock.1
+20-402 files

OpenBSD/src 0JNdKlRusr.bin/mg interpreter.c

   Previously I left the ')' on the end of a list to indicate the end.
   Just to get things working. Best get rid of that nonsense sooner
   rather than later.
VersionDeltaFile
1.3+24-14usr.bin/mg/interpreter.c
+24-141 files

OpenBSD/src jWPSsIausr.bin/systat engine.c

   Make systat flushing output after a page display in rawmode (flags -b or -B)

   ok millert@ kurt@
   code suggested by otto@
VersionDeltaFile
1.24+2-1usr.bin/systat/engine.c
+2-11 files

OpenBSD/src PkPI6TQsbin/mount mount.c

   Adapt to POSIX realpath(3); if it returns NULL, use the mount path as-is.
   Fixes an inability to mount via diskuid.
   Also use mntpath, not *argv, on error for more accurate messages.
   OK martijn@ mlarkin@
VersionDeltaFile
1.73+8-9sbin/mount/mount.c
+8-91 files

OpenBSD/src zdOIfN2sys/arch/amd64/isa clock.c

   i8254_delay(): simplify tick computation

   Back in the mid-90s these optimizations probably made sense, but
   these days the compiler will produce even better code if we just
   explicitly use 64-bit math and do the obvious thing.

   joerg at netbsd.org even popped in on tech@ to agree.

   ok guenther@
VersionDeltaFile
1.30+6-29sys/arch/amd64/isa/clock.c
+6-291 files

OpenBSD/src vU7HrHJsbin/dhclient dhclient.c

   Keep dhclient.leases.<if> O_EXLOCK file descriptor open for the
   lifefime of the dhclient instance. Use O_NONBLOCK so RTM_* messages
   are seen while trying to open the O_EXLOCK file descriptor.

   Prevents a possible race during startup, ensuring only one dhclient
   instance can be configuring an interface. Improves responsiveness to
   interface changes during startup.
VersionDeltaFile
1.645+3-4sbin/dhclient/dhclient.c
+3-41 files

OpenBSD/src bzRC0w4sys/kern uipc_mbuf.c subr_pool.c, sys/sys pool.h

   After the kernel has reached the sysclt kern.maxclusters limit,
   operations get stuck while holding the net lock.  Increasing the
   limit did not help as there was no wakeup of the waiting pools.  So
   introduce pool_wakeup() and run through the mbuf pool request list
   when the limit changes.
   OK dlg@ visa@
VersionDeltaFile
1.272+11-3sys/kern/uipc_mbuf.c
1.228+7-1sys/kern/subr_pool.c
1.77+2-1sys/sys/pool.h
+20-53 files

OpenBSD/src LMtkglLusr.sbin/bgpd bgpd.c bgpd.h

   When allocating socketpair() increase their send and receive buffers to
   4 times the read size. This helps to increase the efficency of poll()
   since now most of the time the read and write call can operate on full
   buffers.
   OK benno@ phessler@
VersionDeltaFile
1.220+43-13usr.sbin/bgpd/bgpd.c
1.389+4-3usr.sbin/bgpd/bgpd.h
+47-162 files

OpenBSD/src T6WhaM6usr.bin/tmux mode-tree.c

   Add a few vi(1) key aliases, from D Ben Knoble.
VersionDeltaFile
1.35+5-1usr.bin/tmux/mode-tree.c
+5-11 files

OpenBSD/src xBUIVq2usr.bin/tmux tmux.1

   More man page fixes from lacygoill at lacygoill dot me, GitHub issue
   1805.
VersionDeltaFile
1.678+34-28usr.bin/tmux/tmux.1
+34-281 files

OpenBSD/src 2JD9LcOsys/net if_aggr.c

   try to notify the partner when the port is going away or down.

   by notify i mean we send an lacp packet with our collecting and
   distributing flags cleared, which should tell the remote system
   that it should no longer handle packets on their port as part of
   their aggregation. this is implemented by "unselecting" a port.

   if an active port is going away, ie, being removed from an aggr via
   "ifconfig aggr0 -trunkport port0", all that happens is software
   state on our side changes and we stop considering the interface as
   part of the aggr interface. the partner system is otherwise oblivious
   and can continue to send us packets until its expiry timeout fires
   because it doesn't know any better.

   we already intercept a ports ioctl handling, so if someone goes
   "ifconfig portX down" while it is attached to an aggr, we can catch
   that before the underlying driver actually tears the rings down, and
   we still have a chance to try and send a packet to the peer. this
   is useful because our drivers generally do not drop the physical
   link, so again, the partner system is oblivious to the change on
   our side until its expiry timer fires.

   expiry timeouts can be up to 90 seconds away, which is a lot of
   traffic to blackhole. sending the notification to the parnter means
   they withdraw this link at the same time the local system is pulling

    [9 lines not shown]
VersionDeltaFile
1.16+16-1sys/net/if_aggr.c
+16-11 files

OpenBSD/src RzjdmD7lib/libpcap nametoaddr.c

   add "slow" to the list of ethernet protocol names.

   this allows "tcpdump ether proto slow", which makes looking at lacp
   frames a bit easier.
VersionDeltaFile
1.22+2-1lib/libpcap/nametoaddr.c
+2-11 files

OpenBSD/src HMVv5Omsys/net if_aggr.c

   default (ie, reset) the partner info when a ports link goes down.

   this doesnt seem to be mentioned in the spec, but is a sensible
   thing to do if you think about it. all the switches i've tried also
   do this, so there's some consensus about it being sensible.

   this is done in the link state handler rather than being added to
   one of the state machines. the idea is to keep the state machines
   as close to what's in the spec as possible.
VersionDeltaFile
1.15+3-1sys/net/if_aggr.c
+3-11 files

OpenBSD/src 9cHDIldsys/net if_aggr.c

   export all the partner info to userland, not just what ifconfig prints.
VersionDeltaFile
1.14+14-1sys/net/if_aggr.c
+14-11 files

OpenBSD/src BBn1F24regress/usr.bin/ssh scp.sh scp-ssh-wrapper.sh

   add regression tests for scp for out-of-destination path file creation
   by Harry Sintonen via Jakub Jelen in bz3007

OpenBSD/src q8KW248usr.bin/ssh ssh-keygen.c ssh-keygen.1

   Accept the verbose flag when searching for host keys in known hosts
   (i.e. "ssh-keygen -vF host") to print the matching host's random-
   art signature too. bz#3003 "amusing, pretty" deraadt@
VersionDeltaFile
1.338+10-2usr.bin/ssh/ssh-keygen.c
1.162+3-2usr.bin/ssh/ssh-keygen.1
+13-42 files

OpenBSD/src A4bXfLqshare/man/man9 vwaitforio.9, sys/kern vfs_subr.c spec_vnops.c

OpenBSD/src XA6EO7Ushare/man/man9 buffercache.9, sys/kern vfs_bio.c

OpenBSD/src 580CEmzsys/arch/armv7/exynos exuart.c, sys/dev/fdt mvuart.c

   ttysleep(): drop unused timeout parameter

   All callers sleep indefinitely.

   With help from visa@.

   ok visa@, ratchov@, kn@