mvc/model - implement getDescription() in NetworkAliasField. As this field type acts as a single (non-list) type, we need to return the description from here as well as BaseListField's implementation doesn't apply here.
(cherry picked from commit 697992bb53c46e7f365a33e7a2fc271051f8e2ac)
mvc/model - BaseListField replace array_map+strval for loop with cast to preserve execution time. The mapping with strval seems to be rather slow, a simple cast seems to be roughly 4 times faster.
(cherry picked from commit b139e33e4c9b00b35f8263b469ba2fe022d1e23e)
mvc - change exception handling in runMigrations() to avoid mismatches in attributes being silently ignored.
When a migration tries to address an non existing attribute, a InvalidArgumentException is thrown, but only partially noted in the log.
It's likely safer to abort the migration if steps fail and send the error to the log for further inspection.
(cherry picked from commit 14ea1b96e8923ca0a571e73124930f86ecbd63ae)
interfaces: evidence suggests + 2 is better than + 1 #7400
The + 1 was completely arbitrary to begin with (derived from
FreeBSD scripting), but if part of the system needs longer to
cope with tentative state then this would be an easy way to
make it more reliable.
If + 3 makes sense for the next person is something I want to
doubt, however.
Special thanks go to @Wireheadbe for pursuing and testing this.
(cherry picked from commit f2e60c18f66a4bcf712078ea718fdb6a95385f55)
fix: :bug: Update field separator for Kea DHCP Subnet Form and Model (#7418)
Co-authored-by: Katerina Ford <kford at madtechnicalsolutions.com>
(cherry picked from commit c1548926ad0bcf3ed0fb10e75c3437ffbb0d329b)
interfaces: move radvd and rtsold to system log where they belong
We've long moved dhcp6c to this spot but we're still missing a bit of
context during debugging, e.g. why rtsold keeps restarting dhcp6c with
a SIGHUP.
(cherry picked from commit b27881c4361a21959a66283789f875c813bbd8d1)
(cherry picked from commit fd7ec1b8044730879022666629af36d1d218d140)
mvc - cleanups for https://github.com/opnsense/core/issues/6389
* remove unused FactoryDefault() in tests
* refactor FactoryDefault() config access to new AppConfig class
* remove unused code in afterExecuteRoute() `$this->response->getHeaders()->get("Status")` will never be null
