OPNSense/core 5ec640asrc/opnsense/mvc/app/library/OPNsense/Mvc Router.php Request.php

mvc - work in progress to replace Phalcon Application()

https://github.com/opnsense/core/issues/6389
DeltaFile
+187-0src/opnsense/mvc/app/library/OPNsense/Mvc/Router.php
+91-0src/opnsense/mvc/app/library/OPNsense/Mvc/Request.php
+88-0src/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php
+70-0src/opnsense/mvc/app/library/OPNsense/Mvc/Session.php
+50-0src/opnsense/mvc/app/library/OPNsense/Mvc/Response.php
+38-0src/opnsense/mvc/app/library/OPNsense/Mvc/Controller.php
+524-01 files not shown
+560-07 files

OPNSense/core b17855dsrc/opnsense/mvc/app/library/OPNsense/Mvc Router.php Dispatcher.php

mvc - work in progress to replace Phalcon Application()

https://github.com/opnsense/core/issues/6389
DeltaFile
+153-0src/opnsense/mvc/app/library/OPNsense/Mvc/Router.php
+104-0src/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php
+48-0src/opnsense/mvc/app/library/OPNsense/Mvc/Response.php
+38-0src/opnsense/mvc/app/library/OPNsense/Mvc/Request.php
+38-0src/opnsense/mvc/app/library/OPNsense/Mvc/Controller.php
+36-0src/opnsense/mvc/app/library/OPNsense/Mvc/Headers.php
+417-01 files not shown
+451-07 files

OPNSense/core 20a8006src/opnsense/mvc/app/config loader.php, src/opnsense/mvc/app/library/OPNsense/Autoload Loader.php

mvc - replace Phalcon autoloader with simplified version of our own. for https://github.com/opnsense/core/issues/6389
DeltaFile
+63-0src/opnsense/mvc/app/library/OPNsense/Autoload/Loader.php
+9-17src/opnsense/mvc/script/load_phalcon.php
+8-12src/opnsense/mvc/app/config/loader.php
+80-293 files

OPNSense/core 3d71277src/opnsense/mvc/app/config loader.php, src/opnsense/mvc/app/library/OPNsense/Autoload Loader.php

mvc - replace Phalcon autoloader with simplified version of our own. for https://github.com/opnsense/core/issues/6389
DeltaFile
+63-0src/opnsense/mvc/app/library/OPNsense/Autoload/Loader.php
+9-18src/opnsense/mvc/script/load_phalcon.php
+8-12src/opnsense/mvc/app/config/loader.php
+80-303 files

OPNSense/core ab76fb0src/opnsense/mvc/app/controllers/OPNsense/Base ApiControllerBase.php, src/opnsense/mvc/app/library/OPNsense/Core Shell.php Config.php

mvc - cleanups for https://github.com/opnsense/core/issues/6389

* remove unused FactoryDefault() in tests
* refactor FactoryDefault() config access to new AppConfig class
* remove unused code in afterExecuteRoute() `$this->response->getHeaders()->get("Status")` will never be null
DeltaFile
+8-13src/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php
+1-10src/opnsense/mvc/tests/setup.php
+4-3src/opnsense/mvc/app/library/OPNsense/Core/Shell.php
+2-2src/opnsense/mvc/app/library/OPNsense/Core/Config.php
+15-284 files

OPNSense/core 3c17903src/opnsense/mvc/app/library/OPNsense/Core Backend.php

mvc-Backend: remove unused $timeout parameter in configdStream() and implement simulate_mode for testing purposes (ui_devtools)
DeltaFile
+16-9src/opnsense/mvc/app/library/OPNsense/Core/Backend.php
+16-91 files

OPNSense/core fdde2f9src/opnsense/www/css dashboard.css, src/opnsense/www/js/widgets BaseTableWidget.js SystemInformation.js

dashboard: add widget CSS grid implementation for tables with top headers
DeltaFile
+103-80src/opnsense/www/js/widgets/BaseTableWidget.js
+42-8src/opnsense/www/css/dashboard.css
+4-4src/opnsense/www/js/widgets/SystemInformation.js
+149-923 files

OPNSense/core 66c684bsrc/opnsense/mvc/app/models/OPNsense/Interfaces Vip.php

fix typo in message about "outboud nat rule" (#7429)

* fix typo in message about "outboud nat rule"

* Removed unused $unqiue_addrs (with typo)

* Restore and fix typo $unique_addrs
DeltaFile
+2-2src/opnsense/mvc/app/models/OPNsense/Interfaces/Vip.php
+2-21 files

OPNSense/core a36b700src/opnsense/service/conf/actions.d actions_system.conf

system: regression in https://github.com/opnsense/core/commit/7f6f55814f0447162acdc431689d464ff2b06471, wrong parameter for configd action
DeltaFile
+1-1src/opnsense/service/conf/actions.d/actions_system.conf
+1-11 files

OPNSense/core 886ee06src/etc/inc system.inc

system: disable userspace core dumps by default

Was suggested by @lattera on 93e0d1474.
DeltaFile
+1-0src/etc/inc/system.inc
+1-01 files

OPNSense/core 94263besrc/etc config.xml.sample, src/etc/inc/xmlrpc legacy.inc

config: cleanup non existing load_balancer section.
DeltaFile
+0-43src/etc/config.xml.sample
+1-1src/etc/inc/xmlrpc/legacy.inc
+0-2src/opnsense/mvc/app/models/OPNsense/Firewall/Alias.php
+1-463 files

OPNSense/core c901230src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api LogController.php NetworkinsightController.php, src/opnsense/mvc/app/library/OPNsense/Core SanitizeFilter.php

src: style sweep
DeltaFile
+2-3src/opnsense/mvc/app/library/OPNsense/Core/SanitizeFilter.php
+1-1src/opnsense/mvc/app/models/OPNsense/Base/Validators/Url.php
+1-1src/opnsense/mvc/app/models/OPNsense/Base/Validators/Regex.php
+0-1src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/LogController.php
+0-1src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/NetworkinsightController.php
+0-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/CountryField.php
+4-83 files not shown
+4-119 files

OPNSense/core eea9c5csrc/opnsense/mvc/app/library/OPNsense/Backup GDrive.php

system: adjust log levels in google drive backup; closes #7427
DeltaFile
+2-2src/opnsense/mvc/app/library/OPNsense/Backup/GDrive.php
+2-21 files

OPNSense/core f7999a7src/opnsense/mvc/app/controllers/OPNsense/Core/Api FirmwareController.php DashboardController.php, src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api FirewallController.php LogController.php

mvc - replace  Phalcon\Filter classes for simple SanitizeFilter wrapper implementing the filters we actually use.

for https://github.com/opnsense/core/issues/6389
DeltaFile
+101-0src/opnsense/mvc/app/library/OPNsense/Core/SanitizeFilter.php
+9-52src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php
+5-24src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/FirewallController.php
+3-12src/opnsense/mvc/app/controllers/OPNsense/IDS/Api/ServiceController.php
+3-6src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/LogController.php
+7-0src/opnsense/mvc/app/controllers/OPNsense/Core/Api/DashboardController.php
+128-944 files not shown
+136-10510 files

OPNSense/core 0dc6089src/opnsense/mvc/app/controllers/OPNsense/Base ApiMutableModelControllerBase.php, src/opnsense/mvc/app/controllers/OPNsense/IDS/Api SettingsController.php

mvc - replace \Phalcon\Filter\Validation\Exception  with \OPNsense\Base\ValidationException (both simple empty Exception classes).

for https://github.com/opnsense/core/issues/6389
DeltaFile
+35-0src/opnsense/mvc/app/models/OPNsense/Base/ValidationException.php
+17-17src/opnsense/mvc/app/controllers/OPNsense/IDS/Api/SettingsController.php
+11-11src/opnsense/mvc/app/controllers/OPNsense/Monit/Api/SettingsController.php
+11-11src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/Api/SettingsController.php
+7-7src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php
+7-7src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/IPPortFieldTest.php
+88-5325 files not shown
+141-10531 files

OPNSense/core 7d212f3src/opnsense/mvc/app/models/OPNsense/IPsec Swanctl.xml

VPN: IPsec: Connections - allow the equal sign for identity parsing as specified in https://docs.strongswan.org/docs/5.9/config/identityParsing.html, closes https://github.com/opnsense/core/issues/7424
DeltaFile
+4-4src/opnsense/mvc/app/models/OPNsense/IPsec/Swanctl.xml
+4-41 files

OPNSense/core 6dbdb2f. plist, src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes UrlField.php

mvc - replace Phalcon\Filter\Validation\Validator\Url with new native OPNsense\Base\Validators\Url validator

for https://github.com/opnsense/core/issues/6389
DeltaFile
+59-0src/opnsense/mvc/app/models/OPNsense/Base/Validators/Url.php
+1-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/UrlField.php
+1-0plist
+61-13 files

OPNSense/core 9ab0edb. plist, src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes TextField.php BooleanField.php

mvc - replace Phalcon\Filter\Validation\Validator\Regex  with new native OPNsense\Base\Validators\Regex validator

for https://github.com/opnsense/core/issues/6389
DeltaFile
+64-0src/opnsense/mvc/app/models/OPNsense/Base/Validators/Regex.php
+3-3src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/TextFieldTest.php
+1-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/TextField.php
+1-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BooleanField.php
+1-0plist
+70-55 files

OPNSense/core b10c17f. plist, src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes EmailField.php

mvc - replace Phalcon\Filter\Validation\Validator\Email with new native OPNsense\Base\Validators\Email validator.

for https://github.com/opnsense/core/issues/6389
DeltaFile
+58-0src/opnsense/mvc/app/models/OPNsense/Base/Validators/Email.php
+1-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/EmailField.php
+1-0plist
+60-13 files

OPNSense/core c34b11d. plist, src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes NumericField.php

mvc - replace Phalcon\Filter\Validation\Validator\Numericality with new native OPNsense\Base\Validators\Numericality validator.

for https://github.com/opnsense/core/issues/6389
DeltaFile
+59-0src/opnsense/mvc/app/models/OPNsense/Base/Validators/Numericality.php
+1-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/NumericField.php
+1-0plist
+61-13 files

OPNSense/core 5dd5426. plist, src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes BaseField.php TextField.php

mvc - replace Phalcon\Filter\Validation\Validator\PresenceOf with new native OPNsense\Base\Validators\PresenceOf validator.

for https://github.com/opnsense/core/issues/6389
DeltaFile
+58-0src/opnsense/mvc/app/models/OPNsense/Base/Validators/PresenceOf.php
+1-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php
+1-1src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php
+1-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/TextField.php
+0-2src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/UpdateOnlyTextField.php
+1-0plist
+62-56 files

OPNSense/core 28c9b45src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes ModelRelationField.php BaseListField.php, src/opnsense/mvc/app/models/OPNsense/Base/Validators InclusionIn.php

mvc - replace Phalcon\Filter\Validation\Validator\InclusionIn with new native OPNsense\Base\Validators\InclusionIn validator.

for https://github.com/opnsense/core/issues/6389
DeltaFile
+59-0src/opnsense/mvc/app/models/OPNsense/Base/Validators/InclusionIn.php
+3-3src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ModelRelationFieldTest.php
+0-3src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ModelRelationField.php
+1-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseListField.php
+0-2src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/CountryField.php
+0-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/PortField.php
+63-102 files not shown
+64-118 files

OPNSense/core 68b0397src/opnsense/mvc/app/models/OPNsense/Base/Menu MenuSystem.php

menusystem - replace phalcon config usage with AppConfig.

for https://github.com/opnsense/core/issues/6389
DeltaFile
+4-6src/opnsense/mvc/app/models/OPNsense/Base/Menu/MenuSystem.php
+4-61 files

OPNSense/core 37696d6src/opnsense/mvc/app/controllers/OPNsense/Wireguard/Api ClientController.php, src/opnsense/mvc/app/views/OPNsense/Wireguard general.volt

VPN: WireGuard: Peer generator - add MTU when set on the instance, closes https://github.com/opnsense/core/issues/7422
DeltaFile
+4-0src/opnsense/mvc/app/views/OPNsense/Wireguard/general.volt
+1-0src/opnsense/mvc/app/controllers/OPNsense/Wireguard/Api/ClientController.php
+5-02 files

OPNSense/core db89247src/opnsense/scripts/filter read_log.py, src/opnsense/service/conf/actions.d actions_filter.conf

firewall: initial proposal for filterlog streaming

while this certainly doesn't account for all use cases, the streaming action is isolated enough to build from. For the use case of the new filter live log widget, starting from scratch on each action should be enough for now.
DeltaFile
+117-84src/opnsense/scripts/filter/read_log.py
+6-0src/opnsense/service/conf/actions.d/actions_filter.conf
+123-842 files

OPNSense/core 51148easrc/opnsense/mvc/app/config AppConfig.php, src/opnsense/mvc/app/controllers/OPNsense/Core/Api DashboardController.php

src: style sweep
DeltaFile
+6-4src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/AliasNameField.php
+2-2src/opnsense/mvc/app/config/AppConfig.php
+2-2src/opnsense/mvc/app/library/OPNsense/Core/Csrf.php
+1-1src/opnsense/mvc/app/controllers/OPNsense/Core/Api/DashboardController.php
+1-1src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/NetworkAliasFieldTest.php
+1-1src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/VirtualIPFieldTest.php
+13-118 files not shown
+20-1814 files

OPNSense/core f2e60c1src/etc rc.newwanipv6

interfaces: evidence suggests + 2 is better than + 1 #7400

The + 1 was completely arbitrary to begin with (derived from
FreeBSD scripting), but if part of the system needs longer to
cope with tentative state then this would be an easy way to
make it more reliable.

If + 3 makes sense for the next person is something I want to
doubt, however.

Special thanks go to @Wireheadbe for pursuing and testing this.
DeltaFile
+1-1src/etc/rc.newwanipv6
+1-11 files

OPNSense/core cd0e45esrc/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes AliasNameField.php AliasContentField.php

Firewall: Aliases - remove Phalcon component usage in model

for https://github.com/opnsense/core/issues/6389
DeltaFile
+17-21src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/AliasNameField.php
+0-2src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/AliasContentField.php
+17-232 files

OPNSense/core 100aac2src/opnsense/mvc/app/config AppConfig.php, src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes NetworkAliasFieldTest.php VirtualIPFieldTest.php

mvc-unittests : remove Phalcon\Di\FactoryDefault usage and support partial app config updates in AppConfig to support different config files in the unit tests.

for https://github.com/opnsense/core/issues/6389
DeltaFile
+21-0src/opnsense/mvc/app/config/AppConfig.php
+2-2src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/NetworkAliasFieldTest.php
+2-2src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/VirtualIPFieldTest.php
+2-2src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/CertificateFieldTest.php
+2-2src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/AuthGroupFieldTest.php
+2-2src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/AuthenticationServerFieldTest.php
+31-102 files not shown
+35-148 files

OPNSense/core cbc01cb. plist, src/opnsense/mvc/app/config AppConfig.php config.php

mvc: replace Phalcon\Config\Config usage for new and simplified OPNsense\Core\AppConfig class.

for https://github.com/opnsense/core/issues/6389
DeltaFile
+76-0src/opnsense/mvc/app/config/AppConfig.php
+2-1src/opnsense/mvc/tests/app/config/config.php
+2-1src/opnsense/mvc/app/config/config.php
+1-0plist
+81-24 files